Uri.origin should never throw

[giregk]

I believe Uri.origin should never throw.

• When host is empty or null, it should return ://
• When scheme is empty or null, it should return
• When both host and scheme are empty or null, it should return an empty string or null

If you disagree with me on these values, then at least Uri.origin should always return null instead of throwing.

Indeed, it is not clear when we use .origin prop on a URI that it can throw which leads to bugs.

My use case : I am writing a password manager, so I have to deal with unknown URIs (such as URIs imported from other tools).
I consider that anything that Uri.tryParse can parse is a valid URI (which seems fair right ?)
I discovered that .origin could throw, which I was of course able to fix by testing properties. But in the future, it is very probable I will forget about this peculiarity and create another bug using .origin an a URI without testing scheme and host first, which is why I filed this issue.

This would be a breaking change. I'm not sure about its impact, but I would say it's easily manageable.

dart version : 3.4.3

[github-actions]

area-core-library, type-enhancement

The Uri.origin method throws an exception when the scheme or host properties are empty or null. This behavior is unexpected and can lead to bugs, especially when dealing with unknown URIs. The user proposes that Uri.origin should always return a value, even if the scheme or host is missing, to avoid unexpected exceptions.

[lrhn]

It's not technically a breaking change to make something not throw an error, but if the current origin behavior is being used as a way to check if two different URIs have the same origin, then returning an empty string instead of an error may cause false positives.

The Dart Uri.origin matches neither the HTML behavior nor the WhatWG URL behavior, so there is no real specification that it's failing to follow. It's not even trying.

I think returning the string "null" would be a reasonable (and semi-compliant) behavior. Maybe we should do that.