Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatter support for sorting includes #23333

Closed
DartBot opened this issue Apr 27, 2015 · 3 comments
Closed

Formatter support for sorting includes #23333

DartBot opened this issue Apr 27, 2015 · 3 comments
Labels
type-enhancement A request for a change that isn't a bug

Comments

@DartBot
Copy link

DartBot commented Apr 27, 2015

This issue was originally filed by [email protected]


It'd be really nice if the formatter sorted includes according to https://www.dartlang.org/articles/style-guide/#ordering (or exposed an option to do so if that's controversial).

In my experience writing Dart for the Mojo project, the formatter takes away 99% of thinking about the style guide. Import alphabetization is the main place I still find myself having to make stylistic code review comments.

@DartBot
Copy link
Author

DartBot commented Apr 28, 2015

This comment was originally written by @zoechi


I think formatter issues should be created in the github.com/dart-lang/dart_style repo

@DartBot
Copy link
Author

DartBot commented Apr 28, 2015

This comment was originally written by @seaneagan


#57172

@lrhn
Copy link
Member

lrhn commented Apr 28, 2015

Added MovedToGithub label.

@kevmoo kevmoo added type-enhancement A request for a change that isn't a bug and removed priority-unassigned labels Mar 1, 2016
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

3 participants