Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint on unnecessary {} in string interpolation #22025

Closed
munificent opened this issue Jan 8, 2015 · 1 comment
Closed

Lint on unnecessary {} in string interpolation #22025

munificent opened this issue Jan 8, 2015 · 1 comment
Assignees
@pq
Labels
analyzer-linter Issues with the analyzer's support for the linter package area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. closed-invalid Closed as we don't believe the reported issue is generally actionable type-enhancement A request for a change that isn't a bug

Comments

@munificent
Copy link
Member

If the interpolated expression is just a simple identifier (and the string after the interpolation is not alphanumeric), then the {} are not needed. Given:

"Hi, ${name}!"

The linter should suggest:

"Hi, $name!"
@pq
Copy link
Member

pq commented Feb 4, 2015

Migrated to github: https://github.com/dart-lang/dart_lint/issues/3

Added Invalid label.

@munificent munificent added Type-Enhancement area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. analyzer-linter Issues with the analyzer's support for the linter package closed-invalid Closed as we don't believe the reported issue is generally actionable labels Feb 4, 2015
@kevmoo kevmoo added type-enhancement A request for a change that isn't a bug and removed type-enhancement labels Mar 1, 2016
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pq pq

Labels
analyzer-linter Issues with the analyzer's support for the linter package area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. closed-invalid Closed as we don't believe the reported issue is generally actionable type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kevmoo @munificent @pq