Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce proliferation of nondefault features #234

Closed
rozbb opened this issue Dec 8, 2022 · 3 comments
Closed

Reduce proliferation of nondefault features #234

rozbb opened this issue Dec 8, 2022 · 3 comments

Comments

@rozbb
Copy link
Contributor

rozbb commented Dec 8, 2022

Some features are accidentally activated transitively. For example, alloc -> rand/alloc, which activates the rand feature. This is a problem if we want to provide semver guarantees for default-on features.

Relatedly, cargo test --no-default-features fails on release/2.0 currently because a lot of our tests use generate() which requires rand (or, consequently, alloc, std,batch, or batch_deterministic). I think a mock.rs` module would be useful here, but we have a lot of doctests that would be affected and it'd look nasty. Maybe worth it regardless though.

@tarcieri
Copy link
Contributor

tarcieri commented Dec 8, 2022

FWIW I was planning on opening a PR to move to weakly activated and namespaced features, which would require MSRV 1.60 but would clean up quite a bit of that spurious feature activation

@tarcieri
Copy link
Contributor

tarcieri commented Dec 8, 2022

Opened #235 to utilize namespaced/weak features

@rozbb
Copy link
Contributor Author

rozbb commented Dec 22, 2022

Resolved by #235

@rozbb rozbb closed this as completed Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants