From 1e80c6d3790edfb71105d74bd29029207051e805 Mon Sep 17 00:00:00 2001 From: Cameron Taggart Date: Thu, 21 Sep 2017 18:21:04 +0300 Subject: [PATCH] use Log.Error if returning false (#259) don't use high priority for converting OriginUrl fix #201 fix #223 --- SourceLink.Create.CommandLine/CreateTask.cs | 6 +++--- SourceLink.Create.Shared/GitCreateTask.cs | 4 ++-- build.ps1 | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/SourceLink.Create.CommandLine/CreateTask.cs b/SourceLink.Create.CommandLine/CreateTask.cs index be6a706..a156a06 100644 --- a/SourceLink.Create.CommandLine/CreateTask.cs +++ b/SourceLink.Create.CommandLine/CreateTask.cs @@ -30,14 +30,14 @@ public override bool Execute() { if(OriginUrl == null) { - Log.LogMessage(MessageImportance.High, "OriginUrl not set"); + Log.LogError("OriginUrl not set"); return false; } url = ConvertUrl(OriginUrl); - Log.LogMessage(MessageImportance.High, "SourceLinkUrl: " + url); + Log.LogMessage(MessageImportance.Normal, "SourceLinkUrl: " + url); if (url == null) { - Log.LogMessage(MessageImportance.High, "unable to convert OriginUrl: " + OriginUrl); + Log.LogError("unable to convert OriginUrl: " + OriginUrl); return false; } } diff --git a/SourceLink.Create.Shared/GitCreateTask.cs b/SourceLink.Create.Shared/GitCreateTask.cs index 6abf0bf..7600031 100644 --- a/SourceLink.Create.Shared/GitCreateTask.cs +++ b/SourceLink.Create.Shared/GitCreateTask.cs @@ -43,14 +43,14 @@ public override bool Execute() var originCmd = Process.RunAndGetOutput("dotnet", originArgs); if (originCmd.ExitCode != 0 || originCmd.OutputLines.Count != 1) { - Log.LogMessage(MessageImportance.High, "unable to find repository origin with: dotnet " + originArgs); + Log.LogError("unable to find repository origin with: dotnet " + originArgs); return false; } var origin = originCmd.OutputLines[0]; url = ConvertUrl(origin); if (url == null) { - Log.LogMessage(MessageImportance.High, "unable to convert origin url: " + origin); + Log.LogError("unable to convert origin url: " + origin); return false; } } diff --git a/build.ps1 b/build.ps1 index fc20319..d011ee1 100644 --- a/build.ps1 +++ b/build.ps1 @@ -1,5 +1,5 @@ $version = '2.3.0' # the version under development, update after a release -$versionSuffix = '-a122' # manually incremented for local builds +$versionSuffix = '-a124' # manually incremented for local builds function isVersionTag($tag){ $v = New-Object Version