Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the Location Tag Binding resource #686

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Add the Location Tag Binding resource #686

wants to merge 7 commits into from

Conversation

akerone
Copy link

@akerone akerone commented Dec 27, 2024

Description of your changes

Fixes #661

I have:

  • Read and followed Crossplane's [contribution process].
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

It hasn't yet.

This is my first PR and I'm following the Configuring a resource guide as best as I can.

@turkenf
Copy link
Collaborator

turkenf commented Dec 27, 2024

/test-examples="examples/tags/v1beta1/locationtagbinding.yaml"

@akerone
Generated code after adding google_tags_location_tag_binding
a50e2db 
Signed-off-by: akerone <[email protected]>
@akerone
Generated code after adding google_tags_location_tag_binding pt.2
0197f38 
Signed-off-by: akerone <[email protected]>
@akerone
Improve the example by using a Cloud Run Service (location-bound) ins…
f4ddf44 
…tead of a Project (global)

Signed-off-by: akerone <[email protected]>
@akerone
Make the Tag Key's parent the project rather than the organization
4753f23 
Signed-off-by: akerone <[email protected]>
@akerone
Manually add the AddResourceConfigurator call for the resource
7dd52b4 
Signed-off-by: akerone <[email protected]>
@akerone
Update example and make reviewable
49086ad 
Signed-off-by: akerone <[email protected]>
@akerone
Change Project Number for a reference, as done in tagbinding.yml
d1c389d 
Signed-off-by: akerone <[email protected]>
@akerone
Copy link
Author

akerone commented Dec 30, 2024

Hi,

I've changed references to an example project number to &{project_id} and &{project_number} like it appears in examples/tags/v1beta1/tagbinding.yaml

@turkenf
Copy link
Collaborator

turkenf commented Jan 2, 2025

/test-examples="examples/tags/v1beta1/locationtagbinding.yaml"

@akerone
Copy link
Author

akerone commented Jan 2, 2025

Hi,

I've just realized that all resources in the TagBinding example have the manual-intervention annotation, so manual testing will be required here too. Since this is my first time, it'll probably take me a while to set up the test environment. Sorry about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ulucinar ulucinar Awaiting requested review from ulucinar ulucinar is a code owner

@sergenyalcin sergenyalcin Awaiting requested review from sergenyalcin sergenyalcin is a code owner

@turkenf turkenf Awaiting requested review from turkenf turkenf is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Request for Location Tag Binding (google_tags_location_tag_binding) resource
2 participants
@akerone @turkenf