Add Artifact registry Repository managed resource #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcbenjemaa
force-pushed
the
feature/artifact-registry
branch
from
54f3467 to
761a6cc
Compare
mcbenjemaa
commented
Feb 13, 2022
| @@ -995,20 +995,6 @@ func newBinaryAuthorizationUpdateFn(in *v1beta2.BinaryAuthorization) UpdateFn { | |||
| } | |||
| } | |||
|
|
|||
| // newAutopilotUpdateFn returns a function that updates the Autopilot of a cluster. | |||
| func newAutopilotUpdateFn(in *v1beta2.Autopilot) UpdateFn { | |||
There was a problem hiding this comment.
Notable change in the API!
Autopilot is immutable, therefore no need to request an update!
mcbenjemaa
force-pushed
the
feature/artifact-registry
branch
from
761a6cc to
8332322
Compare
|
Well, go |
mcbenjemaa
force-pushed
the
feature/artifact-registry
branch
7 times, most recently
from
58b0bc1 to
2fab122
Compare
Signed-off-by: Mohamed Chiheb <[email protected]>
mcbenjemaa
force-pushed
the
feature/artifact-registry
branch
from
2fab122 to
7136b5f
Compare
|
Any chance this PR will be merged in the near future? |
|
I don't know if @mcbenjemaa is still working on this PR, there is a TODO to add tests to the resource before it can be merged. I can review it by the end of the week, @stoetti. Just need some update from @mcbenjemaa |
|
Any updates? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mohamed Chiheb [email protected]
Description of your changes
Added support for Artifact registry managed resource.
TODO: Add Tests
Fixes #404
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
GCP
/cc @turkenh @muvaf