Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Links are actually buttons #544

Open
1 task done
Serpentarius13 opened this issue Oct 9, 2024 · 5 comments · May be fixed by #549
Open
1 task done

[Bug] Links are actually buttons #544

Serpentarius13 opened this issue Oct 9, 2024 · 5 comments · May be fixed by #549
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🧹 status: ticket work required Needs more details before it can be worked on

Comments

@Serpentarius13
Copy link

Serpentarius13 commented Oct 9, 2024

Description

In Choose A License page, there's a section called Confused? Need help? and links there are actually buttons which is a terrible UX. Swap them for actual <a>'s !

Reproduction

Open https://chooser-beta.creativecommons.org/ and scroll to bottom

Expectation

Links should be <a> hyperlinks

Screenshots

image

Resolution

  • I would be interested in resolving this bug.
@Serpentarius13 Serpentarius13 added 💻 aspect: code Concerns the software code in the repository 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents labels Oct 9, 2024
@possumbilities possumbilities added 🏁 status: ready for work Ready for work and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Oct 9, 2024
@possumbilities possumbilities moved this from Triage to Backlog in possumbilities Oct 9, 2024
@sid0000007
Copy link

@Serpentarius13 @cc-creativecommons-github-io-bot Can you Please assign it to me.I will make sure to complete this

@possumbilities
Copy link
Contributor

possumbilities commented Oct 23, 2024

After looking through this further, there is a deeper Issue at play here that's difficult to resolve.

These items each looks like a hyperlink in their visual representation. However, under the hood functionally they are in fact buttons. They don't actually navigate anywhere, but instead open popups with further information.

Since this adds complexity to the problem I'm unsure what an adequate route of solution would be. Merely swapping the items from buttons to a would in fact make them more semantically accurate to what they look like, but it would in fact make them less semantically accurate to what they actually behaviorally are, which is buttons.

The underlying issue is that the UX here is at a conflict.

Moving this to 🧹 status: ticket work required Needs more details before it can be worked on until someone comes up with a better route of solution here.

@possumbilities possumbilities added 🧹 status: ticket work required Needs more details before it can be worked on and removed 🏁 status: ready for work Ready for work labels Oct 23, 2024
@Serpentarius13
Copy link
Author

Serpentarius13 commented Oct 23, 2024

After looking through this further, there is a deeper Issue at play here that's difficult to resolve.

These items each looks like a hyperlink in their visual representation. However, under the hood functionally they are in fact buttons. They don't actually navigate anywhere, but instead open popups with further information.

Since this adds complexity to the problem I'm unsure what an adequate route of solution would be. Merely swapping the items from buttons to a would in fact make them more semantically accurate to what they look like, but it would in fact make them less semantically accurate to what they actually behaviorally are, which is buttons.

The underlying issue is that the UX here is at a conflict.

Moving this to 🧹 status: ticket work required Needs more details before it can be worked on until someone comes up with a better route of solution here.

Yea, I'm sorry for misunderstanding. I propose to make them Accordion's, that's how faqs are usually done

@bhat-shubham
Copy link

Hey @possumbilities if this isn't fixed yet(which i believe it isn't as it is the same as it as described in the issue on the site)
i can work on this issue and make it something like-
image
would you be okay with this type of accordion?

@ShreyPurohit
Copy link

ShreyPurohit commented Jan 18, 2025

Proposal for Improving UX in the "Choose A License" Page

Description of the Issue

In the "Choose A License" page, under the section titled "Confused? Need Help?", the listed links are implemented as buttons instead of proper <a> tags. This implementation creates a poor user experience (UX) because:

  • Buttons are generally expected to perform actions (e.g., submitting a form) rather than navigating users to different pages.
  • Links or interactive components are better suited for navigation or displaying additional information.

Proposed Solution

Instead of simple links or buttons, I propose replacing this section with an accordion component. This approach would:

  1. Enhance the UX by allowing users to expand and read more details directly within the page without navigating away.
  2. Maintain a clean and interactive design.
  3. Be accessible and keyboard-friendly to support all users.

Accordion Implementation

Each question in the "Confused? Need Help?" section can be converted into an accordion item. When a user clicks on a question, the corresponding answer or additional details will expand below with smooth animation implemented.

Benefits of This Fix

  • Improved UX: Users can expand and read more information directly without navigating away, reducing context switching.
  • Enhanced Accessibility: Accordions are compatible with screen readers and keyboard navigation, ensuring inclusivity.
  • Modern and Interactive Design: The accordion design keeps the page clean while maintaining interactive functionality.
  • Scalability: New questions can easily be added as additional accordion items.

Request

I’d like to work on replacing the current implementation with the proposed accordion design. Please assign this issue to me, and I’ll ensure the solution adheres to the repository's code and accessibility standards.

Thank you for considering my contribution!
@possumbilities @Serpentarius13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🧹 status: ticket work required Needs more details before it can be worked on
Projects
Status: Backlog
5 participants