Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verify_proof comments are incorrect #97

Open
acolytec3 opened this issue Sep 6, 2024 · 0 comments
Open

verify_proof comments are incorrect #97

acolytec3 opened this issue Sep 6, 2024 · 0 comments

Comments

@acolytec3
Copy link

I've found 2 issues in the comments for verify_proof that need clarification:

  1. This line says that the commitment should be the uncompressed 64 byte representation of the commitment but the actual code that parses the commitment bytes wants 32 bytes (seemingly the serialized/compressed commitment).

  2. The z_index parameter says it should be a one byte value between 1-256. Is the underlying code wanting a 1-256 or a zero-indexed value between 0-255?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant