Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO Verkle Trie Trie #67

Open
9 tasks
ControlCplusControlV opened this issue Dec 24, 2022 · 0 comments
Open
9 tasks

TODO Verkle Trie Trie #67

ControlCplusControlV opened this issue Dec 24, 2022 · 0 comments

Comments

@ControlCplusControlV
Copy link
Contributor

trie.rs

  • - root_commitment This is needed for proofs, can we remove the root hash as the root?
  • - In new We should have a way to populate the cache from the persistent db here. we first check if it is an new database and if it is not then we pull in all nodes on level 3 or lower. This way, if it is not in the cache, we know it is not in the key-value db either
  • - child_branch this does not need to be optional
  • - This is the only place here, where we require a get_leaf should we just allow users to update keys to be the same value and catch it maybe when we compute the delta? Rationale is that get_leaf only gets a single 32 bytes and database work in pages of ~4Kb
  • - Update comments on this function on Ins
  • - flush maybe make this private, and automatically flush after each insert. This will promote users to use insert(). If the amount of items in insert is too much, we will need to chop it up. and flush multiple times
  • - Clean up path_difference
  • - paths_from_relative Is this hurting performance? If so can we rewrite it to be more efficient? Eagerly, we can use SmallVec32
  • - Is this manual test needed, or can we add it as a consistency test? insert_key1_val1_key2_val2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant