Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for uses of .unwrap and .expect #36

Open
kevaundray opened this issue Dec 12, 2021 · 4 comments
Open

Check for uses of .unwrap and .expect #36

kevaundray opened this issue Dec 12, 2021 · 4 comments
Assignees
Labels

Comments

@kevaundray
Copy link
Contributor

No description provided.

@ControlCplusControlV
Copy link
Contributor

Do you mind if I take this issue? It would take me a day or 2 to fix given my schedule, but I can move errors to anyhow and have functions properly propagate errors all the way up via results

@kevaundray
Copy link
Contributor Author

Hey Yep sure, though my understanding is that anyhow is more suited for applications and not libraries. Here is a link to an article about it the distinction: https://nick.groenen.me/posts/rust-error-handling/#libraries-versus-applications

@ControlCplusControlV
Copy link
Contributor

I suggested anyhow because I have the greatest familiarity with it, but I agree with the article you sent and hadn't really stopped to consider the distinction in usecase before. I can move errors to thiserror instead so hopefully downstream consumers can see better errors

@kevaundray
Copy link
Contributor Author

That sounds great, thank you for taking this on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants