Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistent naming for bonding pool addresses #37

Open
harisang opened this issue Sep 17, 2024 · 1 comment
Open

Consistent naming for bonding pool addresses #37

harisang opened this issue Sep 17, 2024 · 1 comment
Assignees
@bram-vdberg
Labels
E:9.1 Streamline mainnet payouts process See https://github.com/cowprotocol/pm/issues/80 for details

Comments

@harisang
Copy link
Contributor

We use the names pool and pool_address in different places to refer to the same thing. We should unify the naming convention throughout this repo and the solver-rewards repo.
@harisang harisang mentioned this issue Sep 17, 2024
Merged
@fleupold
Copy link
Contributor

fleupold commented Dec 6, 2024

Is this still relevant?

@fleupold fleupold added the E:9.1 Streamline mainnet payouts process See https://github.com/cowprotocol/pm/issues/80 for details label Dec 6, 2024
@bram-vdberg bram-vdberg self-assigned this Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bram-vdberg bram-vdberg

Labels
E:9.1 Streamline mainnet payouts process See https://github.com/cowprotocol/pm/issues/80 for details
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fleupold @harisang @bram-vdberg