Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Approving modal when connected to MM #3425

Closed
elena-zh opened this issue Nov 23, 2023 · 1 comment · Fixed by #4244
Closed

Change Approving modal when connected to MM #3425

elena-zh opened this issue Nov 23, 2023 · 1 comment · Fixed by #4244
Labels
Bug Something isn't working Low Severity indicator for defects. It won't cause any major break-down of the system Regression

Comments

@elena-zh
Copy link

elena-zh commented Nov 23, 2023 •
edited
Loading

Reported in https://cowservices.slack.com/archives/C06002PRF37/p1700670424983679

  1. Connect to MM
  2. Select a token that requires an onchain approval, specify a trade with this token
  3. Press on the Approve button and check the waiting modal

AR: the text there does not correspond to buttons' naming in the MM
image

ER: should correspond (or just return to the regular modal when approve a token using MM)
@elena-zh elena-zh added Bug Something isn't working Low Severity indicator for defects. It won't cause any major break-down of the system labels Nov 23, 2023
@elena-zh elena-zh changed the title Change waitning for approval modal when connected to MM Change waiting for approval modal when connected to MM Nov 23, 2023
@elena-zh elena-zh changed the title Change waiting for approval modal when connected to MM Change Approving modal when connected to MM Nov 23, 2023
@elena-zh
Copy link
Author

Might be related to #3336

@shoom3301 shoom3301 mentioned this issue Apr 15, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working Low Severity indicator for defects. It won't cause any major break-down of the system Regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(approve): remove Metamask special approve flow cowprotocol/cowswap
1 participant
@elena-zh