Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use cache when building library #3383

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Conversation

anxolin
Copy link
Contributor

@anxolin anxolin commented Nov 10, 2023

Summary

This PR removes a yarn add nx which was adding it "again" into our dependencies (we have it in the devDependencies)

The problems are:

  • This adds another version (latest, instead of the one we have)
  • This command brings also all the other dependencies does a normal yarn install implicitly), however it doesn't use the node_modules cache

Lastly, i took this opportunity to rename the workflow to NPM since its easier to find it. publish is too generic, and can be confused with our deploy workflow which deploys CoW Swap

CTX:
https://cowservices.slack.com/archives/C0361CDG8GP/p1699624696566869?thread_ts=1699623116.624319&cid=C0361CDG8GP

Copy link

vercel bot commented Nov 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
cosmos ✅ Ready (Inspect) Visit Preview Nov 10, 2023 2:11pm
swap-dev ✅ Ready (Inspect) Visit Preview Nov 10, 2023 2:11pm
widget-configurator ✅ Ready (Inspect) Visit Preview Nov 10, 2023 2:11pm

@anxolin anxolin marked this pull request as ready for review November 10, 2023 14:11
@anxolin anxolin requested a review from a team November 10, 2023 14:13
@anxolin anxolin changed the title fix: use cache when building library chore: use cache when building library Nov 10, 2023
@anxolin
Copy link
Contributor Author

anxolin commented Nov 10, 2023

merging this to try the workflow, happy to revert back if necesary

@anxolin anxolin merged commit 9b9b598 into main Nov 10, 2023
7 of 8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 10, 2023
@alfetopito alfetopito deleted the use-node-modules-cache branch November 10, 2023 14:19
@alfetopito
Copy link
Collaborator

merging this to try the workflow, happy to revert back if necesary

Probably it won't work.
Needs to be merged to the default branch to have the GH action updated

@anxolin
Copy link
Contributor Author

anxolin commented Nov 10, 2023

👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants