Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.48.0] [eth flow] Refund didn't work as expected #3218

Closed
anxolin opened this issue Oct 12, 2023 · 0 comments
Closed

[1.48.0] [eth flow] Refund didn't work as expected #3218

anxolin opened this issue Oct 12, 2023 · 0 comments
Labels
Bug Something isn't working Critical Severity indicator for defects. ndicates complete shut-down of the process. Nothing can proceed furt RELEASE Included in the release that is being closed

Comments

@anxolin
Copy link
Contributor

anxolin commented Oct 12, 2023

Description
ETH Flow refund was done, but the UI still showed this:

image

Also, it didn't allow me to refund it myself:

How to Reproduce

  1. Make an ETH Flow order (try to make it expire, not sure how, but probably moving the price below the 200 bips)
  2. The refunded should..... refund you
  3. The UI don't show the refund
  4. Further more, i don't see the CANCEL or REFUND button so i can do it myself

Expected behavior

  1. Detect refund
  2. Allow to refund myself

Additional context

Furthermore, I can see the backend is informing us about the refund, so something is broken (ideally we should be able to use Cosmos to reproduce)

{
    "creationDate": "2023-10-12T14:58:23Z",
    "owner": "0xd02de8da0b71e1b59489794f423fabba2adc4d93",
    "uid": "0x7d512b201971431c15933ebb0b0bb4eec8f4c4c1570ae09c117dba4e8f65cbd5d02de8da0b71e1b59489794f423fabba2adc4d93ffffffff",
    "availableBalance": null,
    "executedBuyAmount": "0",
    "executedSellAmount": "0",
    "executedSellAmountBeforeFees": "0",
    "executedFeeAmount": "0",
    "invalidated": false,
    "status": "expired",
    "class": "market",
    "settlementContract": "0x9008d19f58aabd9ed0d60971565aa8510560ab41",
    "fullFeeAmount": "1309395566328509",
    "solverFee": "1309395566328509",
    "ethflowData": {
        "userValidTo": 1697124479,
        "refundTxHash": "0x5503117f196b3d2e5ed1ba8e1a599b8339310e802033451a6d5301660fbfb2b6",
        "isRefunded": true
    },
    "onchainOrderData": {
        "sender": "0x87a04752e516548b0d5d4df97384c0b22b649179",
        "placementError": null
    },
    "onchainUser": "0x87a04752e516548b0d5d4df97384c0b22b649179",
    "isLiquidityOrder": false,
    "fullAppData": "{\"appCode\":\"CoW Swap\",\"environment\":\"pr\",\"metadata\":{\"orderClass\":{\"orderClass\":\"market\"},\"quote\":{\"slippageBips\":\"200\"}},\"version\":\"0.9.0\"}",
    "sellToken": "0xc02aaa39b223fe8d0a0e5c4f27ead9083c756cc2",
    "buyToken": "0x6b175474e89094c44da98b954eedeac495271d0f",
    "receiver": "0x87a04752e516548b0d5d4df97384c0b22b649179",
    "sellAmount": "19100000000000000",
    "buyAmount": "28891705401796810610",
    "validTo": 4294967295,
    "appData": "0xc9fc66ff9facbaaf3cd642f1aa8a2782e0e90f1b3cbfef3c7c1d7f7e0c16b59a",
    "feeAmount": "900000000000000",
    "kind": "sell",
    "partiallyFillable": false,
    "sellTokenBalance": "erc20",
    "buyTokenBalance": "erc20",
    "signingScheme": "eip1271",
    "signature": "0xd02de8da0b71e1b59489794f423fabba2adc4d93",
    "interactions": {
        "pre": [
            {
                "target": "0xd02de8da0b71e1b59489794f423fabba2adc4d93",
                "value": "0",
                "callData": "0x4c84c1c8"
            }
        ],
        "post": []
    }
}
@anxolin anxolin added Bug Something isn't working Critical Severity indicator for defects. ndicates complete shut-down of the process. Nothing can proceed furt RELEASE Included in the release that is being closed labels Oct 12, 2023
@alfetopito alfetopito changed the title [eth flow] Refund didn't work as expected [1.48.0] [eth flow] Refund didn't work as expected Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Critical Severity indicator for defects. ndicates complete shut-down of the process. Nothing can proceed furt RELEASE Included in the release that is being closed
Projects
None yet
Development

No branches or pull requests

2 participants