Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.48.0] Safe order in signing state forever #3210

Closed
anxolin opened this issue Oct 12, 2023 · 2 comments
Closed

[1.48.0] Safe order in signing state forever #3210

anxolin opened this issue Oct 12, 2023 · 2 comments
Assignees
@anxolin
Labels
Bug Something isn't working RELEASE Included in the release that is being closed

Comments

@anxolin
Copy link
Contributor

anxolin commented Oct 12, 2023 •
edited
Loading

Description

image

How to Reproduce
In safe app

  • select xDAI as sell token
  • ..and GNO as buy token
  • Place an order
  • Even after the TX is mined, the order is still in presign

Issue

I think, the order ID CoW Swap we post, don't match what we sign

https://dev.explorer.cow.fi/gc/orders/0xfb686a036bcb2497cca9b1a3ddf5146223fcbf629cc140197423a6492a664fa150736f4707ed0c7bae86bd801d65377bb37395506527d3d2?tab=overview

See nonce 90, doesn't match that id
https://app.safe.global/transactions/history?safe=gno:0x50736F4707eD0c7bae86bd801d65377BB3739550

Other observations

this doesn't happen in PROD so its something part of this release
@anxolin anxolin added Bug Something isn't working RELEASE Included in the release that is being closed labels Oct 12, 2023
@alfetopito alfetopito changed the title [safe] Order in signing state forever [1.48.0] Safe order in signing state forever Oct 12, 2023
@alfetopito
Copy link
Collaborator

Seems to be fixed by #3213

Using those changes I could not reproduce it

@anxolin
Copy link
Contributor Author

anxolin commented Oct 13, 2023

Indeed! that solved the issue

@anxolin anxolin closed this as completed Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anxolin anxolin

Labels
Bug Something isn't working RELEASE Included in the release that is being closed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alfetopito @anxolin