Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update mailpit to latest #4710

Merged
merged 2 commits into from
Dec 2, 2023
Merged

Update mailpit to latest #4710

merged 2 commits into from
Dec 2, 2023

Conversation

GitBib
Copy link
Contributor

@GitBib GitBib commented Dec 2, 2023 •
edited
Loading

Description

Updated Mailpit Docker container from 1.8 to 'latest'.

Checklist:

  • I've made sure that tests are updated accordingly (especially if adding or updating a template option)
  • I've updated the documentation or confirm that my change doesn't require any updates

Rationale

Enhances performance and security.

browniebroke
browniebroke reviewed Dec 2, 2023
View reviewed changes
Copy link
Member

@browniebroke browniebroke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it's just used in local dev, and that it's apparently not automatically updated, should we specify its version with 'latest'? Or just pin the major version (if it's possible)...

@GitBib
Copy link
Contributor Author

GitBib commented Dec 2, 2023

@browniebroke It looks like a better use of 'latest'

@GitBib GitBib changed the title Update mailpit to 1.10 Update mailpit to latest Dec 2, 2023
@browniebroke browniebroke merged commit fd36435 into cookiecutter:master Dec 2, 2023
12 checks passed
@GitBib GitBib deleted the patch-1 branch December 2, 2023 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@browniebroke browniebroke browniebroke approved these changes

Assignees
No one assigned
Labels
update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GitBib @browniebroke