Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move navbar to the right #4707

Closed
wants to merge 2 commits into from
Closed

Move navbar to the right #4707

wants to merge 2 commits into from

Conversation

reyesvicente
Copy link
Contributor

move nav links to the right

Description

Checklist:

  • I've made sure that tests are updated accordingly (especially if adding or updating a template option)
  • I've updated the documentation or confirm that my change doesn't require any updates

Rationale

Just moved the nav links to the right.

move nav links to the right
@browniebroke browniebroke changed the title Update base.html Move navbar to the right Nov 30, 2023
@foarsitter
Copy link
Collaborator

@reyesvicente what is the reason behind this PR? Can you provide some more context?

@browniebroke
Copy link
Member

browniebroke commented Dec 12, 2023

I too don't see value in merging this, this is a subjective cosmetic tweak, and folks would be 50-50 to get what we currently have vs what is suggested. So without a clear reason, I'd say we keep it as is.

@reyesvicente
Copy link
Contributor Author

reyesvicente commented Dec 13, 2023

@reyesvicente what is the reason behind this PR? Can you provide some more context?

I don't understand why it's in the left in the first place. Normally, navlinks are at the right side of the page. @browniebroke

@browniebroke
Copy link
Member

No clear benefits, so priority to keep it as is. Thanks for the suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants