Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some conversations have multiple actions with no parent #24

Open
iislucas opened this issue Sep 24, 2017 · 1 comment
Open

Some conversations have multiple actions with no parent #24

iislucas opened this issue Sep 24, 2017 · 1 comment
Assignees

Comments

@iislucas
Copy link
Contributor

In particular, there's about 1% of comments that have a section heading introduction at the same time as a comment addition (same revision & timestamp, but separated into 2 actions), e.g.

{  
   "96983583.202.24":{  
      "id":"96983583.202.24",
      "comment_type":"COMMENT_ADDING",
      "content":" From the other notes from other Wikipedia notes, I'm not the only one who questions your judgment.",
      "timestamp":"2006-12-28 19:35:53 UTC",
      "status":"just added",
      "page_title":"User talk:Jinxmchue",
      "user_text":"Sotaman",
      "parent_id":""
   },
   "96983583.24.24":{  
      "id":"96983583.24.24",
      "comment_type":"SECTION_CREATION",
      "content":" ==Bluffs? You see bluffs? I'll call your bluff==",
      "timestamp":"2006-12-28 19:35:53 UTC",
      "status":"just added",
      "page_title":"User talk:Jinxmchue",
      "user_text":"Sotaman",
      "parent_id":""
   },
   "96983583.48.24":{  
      "id":"96983583.48.24",
      "comment_type":"COMMENT_ADDING",
      "content":" Here, visit this link: [EXTERNA_LINK: http://images.google.com/images?q=bluffs&ie;=UTF-8&oe;=UTF-8&rls;=org.mozilla:en-US:official&client;=firefox-a&sa;=N&tab;=wi] Then tell me you see bluffs around Montevideo, much less (as you earlier characterized them) \"spectacular\" bluffs. Sorry if my standards for geographical features are a bit higher than what's seen in your minds eye.",
      "timestamp":"2006-12-28 19:35:53 UTC",
      "status":"just added",
      "page_title":"User talk:Jinxmchue",
      "user_text":"Sotaman",
      "parent_id":"96983583.24.24"
   },
   "97139226.240.240":{  
      "id":"97139226.240.240",
      "comment_type":"COMMENT_ADDING",
      "content":" :Higher?  More like narrower.  Bluffs are not just sheer cliffs.  As I said, check the dictionary.",
      "timestamp":"2006-12-29 14:41:34 UTC",
      "status":"just added",
      "page_title":"User talk:Jinxmchue",
      "user_text":"Jinxmchue",
      "parent_id":"96983583.202.24"
   }
},

We now handle this in the JS by inferring who should be the parent, but we might want to consider doing this in the python in future.

@vegetable68
Copy link
Collaborator

Hmm, this is actually a bug case in the reconstruction code, will fix it. The action is supposed to be divided into a title and a context edit, but the context edit should be linked to the title edit with a reply link.

@vegetable68 vegetable68 self-assigned this Sep 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants