From 3bb4e14fe56449b15478b7e9e66ef31020116d34 Mon Sep 17 00:00:00 2001 From: "Jiaxiao Zhou (Mossaka)" Date: Sat, 16 Nov 2024 13:33:33 -0700 Subject: [PATCH] .github/workflows/ci: add check to runc shim The runc shim, like the containerd-shim, has a 'sync' feature that is not checked by the workspace. Thus we need to add that individually to the CI to get full coverage Signed-off-by: Jiaxiao Zhou (Mossaka) --- .github/workflows/ci.yml | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index db3bb17b..2d963e96 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -22,18 +22,21 @@ jobs: - run: ./scripts/install-protobuf.sh shell: bash - - run: cargo check --examples --tests --all-targets - - run: cargo check --examples --tests --all-targets --all-features - - run: rustup toolchain install nightly --component rustfmt - run: cargo +nightly fmt --all -- --check --files-with-diff + # the "runc" and "containerd-shim" crates have `sync` code that is not covered by the workspace + - run: cargo check -p runc --all-targets + - run: cargo clippy -p runc --all-targets -- -D warnings + - run: cargo check -p containerd-shim --all-targets + - run: cargo clippy -p containerd-shim --all-targets -- -D warnings + + # check the workspace + - run: cargo check --examples --tests --all-targets + - run: cargo check --examples --tests --all-targets --all-features - run: cargo clippy --all-targets -- -D warnings - run: cargo clippy --all-targets --all-features -- -D warnings - # the shim has sync code that is not covered when running with --all-features - - run: cargo clippy -p containerd-shim --all-targets -- -D warnings - - run: cargo doc --no-deps --features docs env: RUSTDOCFLAGS: -Dwarnings