Contributions are made through pull requests into the main branch of the repository. Each pull request should be reviewed with at least one maintainer from each of the affected sections of the code base as well as pass each of the merge requirements.
If branching on the main repository the following naming patterns should be used. In general lisp-case
/spinal-case
/kebab-case
should be used.
Change Type | Naming Pattern |
---|---|
Fix | fix/{issue number}-{short-description} |
Feature | feat/{issue number}-{short-description} |
Documentation | doc/{issue number}-{short-description} |
Other | other/{issue number}-{short-description} |
Requirement | Action |
---|---|
Approval | Non-involved maintainer or core development member create an Approved review on the PR. |
CI | A continuous integration build must pass. |
Code Style | Code must be the same as the rest of the codebase. |
Manual Test | Code must be manually tested to ensure that it is working as intended. |
Other | Other requirements may be imposed, such as a version increment. |
All of these requirements can be bypassed within good reason by a core development member - if this is the case the reason should be commented on the pull request.
Once a merge is approved, a squash merge should occur with the pull request branch deleted afterwards.
Note: this section may be incomplete, review the relevant repository for more information.
Integration | Maintainer |
---|---|
HipChat | @mrkno |
@mrkno | |
Grunt | @Awarua- |
Discord | @Awarua- |
Messenger | @mrkno |
MS/Skype Bots | @Awarua- |
Skype | @mrkno |
Slack | @Awarua- |
Telegram | @phillipadsmith |
Test | @mrkno |
Feature | Maintainer |
---|---|
Docker | @MatthewHartstonge |
Core | core-development Github Team |
Tests | @Awarua- |
Repository | @mrkno |
Translation | Maintainer |
---|---|
en | core-development Github Team |
pl | @p0358 |
hi | @ParasDPain |