Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always show sidebar on PC #73

Open
adeebshihadeh opened this issue Jul 13, 2024 · 4 comments
Open

Always show sidebar on PC #73

adeebshihadeh opened this issue Jul 13, 2024 · 4 comments
Labels
enhancement New feature or request
Milestone

Comments

@adeebshihadeh
Copy link
Contributor

No description provided.

@adeebshihadeh adeebshihadeh added the enhancement New feature or request label Jul 13, 2024
@adeebshihadeh adeebshihadeh added this to the 1.0 milestone Jul 13, 2024
@griffinbaker12
Copy link
Contributor

even when the screen gets reduced? i feel like the old connect site had it right: default open, but if the screen collapses then move it into the sidebar and have it hover over content when expanded. lmk though and I can fix.

@adeebshihadeh
Copy link
Contributor Author

Yeah, just like old connect. Open on big screens, and same behavior as now on small ones.

@35C4n0r
Copy link

35C4n0r commented Aug 3, 2024

@adeebshihadeh I raised a PR for this, can you confirm if this is what we wanted?

@ugtthis
Copy link
Contributor

ugtthis commented Aug 6, 2024

Came up with a design idea that is supposed to be on the leaner side with minimum changes to the overall new-connect UI

Thoughts:

  • A header component(the black bar that runs across at the top) gives the layout a clearer hierarchy. Without the top header component, it looks like there are 2 headers.
  • Having the device name in multiple places close to each other when on desktop mode is redundant because sidebar will be open already displaying the current device that is being displayed
  • When on desktop users should not have an option to collapse the sidebar. Only when on mobile will users be able to open and close the sidebar

new-connect with the sidebar as is open

no-header-component

new-connect with a header component

header-component-1



Design

sidebar-desktop-1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants