You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently for ZIP files PlexusArchiverZipFileResourceCollection is used and PlexusIoZipFileResourceCollection for the rest of the ZIP based file formats (Jar, War, etc). Apart from being inconsistent, there is performance penalty for using PlexusIoZipFileResourceCollection (see codehaus-plexus/plexus-io#12).
According to this comment there are integration tests in Maven Assembly plugin failing when PlexusArchiverZipFileResourceCollection is used for all formats.
Does anybody knows what the issues with PlexusArchiverZipFileResourceCollection are (if there are any - there were some bugs fixed since)? /cc @krosenvold
The text was updated successfully, but these errors were encountered:
Actually I ran the ITs in Maven Assembly(on Windows) and none of them is failing when PlexusIoZipFileResourceCollection is replaced with PlexusArchiverZipFileResourceCollection.
As @slachiewicz pointed out (codehaus-plexus/plexus-io#12 (comment)) PlexusIoZipFileResourceCollection verifies the signatures of the Jar files (if signed). PlexusArchiverZipFileResourceCollection does not so just switching the implementations would not work. We can create another resource collection for Jar based file format that will verify the signatures.
Currently for ZIP files
PlexusArchiverZipFileResourceCollection
is used andPlexusIoZipFileResourceCollection
for the rest of the ZIP based file formats (Jar, War, etc). Apart from being inconsistent, there is performance penalty for usingPlexusIoZipFileResourceCollection
(see codehaus-plexus/plexus-io#12).According to this comment there are integration tests in Maven Assembly plugin failing when
PlexusArchiverZipFileResourceCollection
is used for all formats.Does anybody knows what the issues with
PlexusArchiverZipFileResourceCollection
are (if there are any - there were some bugs fixed since)? /cc @krosenvoldThe text was updated successfully, but these errors were encountered: