Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address collision can lead to unexpected consequences #1129

Closed
c4-submissions opened this issue Oct 23, 2023 · 2 comments
Closed

Address collision can lead to unexpected consequences #1129

c4-submissions opened this issue Oct 23, 2023 · 2 comments
Labels
2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working low quality report This report is of especially low quality unsatisfactory does not satisfy C4 submission criteria; not eligible for awards

Comments

@c4-submissions
Copy link
Contributor

Lines of code

https://github.com/matter-labs/era-system-contracts/blob/main/contracts/ContractDeployer.sol#L1

Vulnerability details

Impact

Address collision to 0x01 or 0x00 will lead to unexpected consequences.

Proof of Concept

sherlock-audit/2023-07-kyber-swap-judging#90
Given the discussion, collision possibility is 2^80

Tools Used

matter-labs/era-system-contracts#6

Recommended Mitigation Steps

Assessed type

Access Control
@c4-submissions c4-submissions added 2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working labels Oct 23, 2023
jacobheun pushed a commit that referenced this issue Oct 24, 2023
@c4-submissions
clash issue #1129
5cb510b
@c4-pre-sort
Copy link

bytes032 marked the issue as low quality report

@c4-pre-sort c4-pre-sort added the low quality report This report is of especially low quality label Oct 31, 2023
@c4-judge c4-judge closed this as completed Nov 1, 2023
@c4-judge
Copy link
Contributor

c4-judge commented Nov 1, 2023

GalloDaSballo marked the issue as unsatisfactory:
Invalid

@c4-judge c4-judge added the unsatisfactory does not satisfy C4 submission criteria; not eligible for awards label Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working low quality report This report is of especially low quality unsatisfactory does not satisfy C4 submission criteria; not eligible for awards
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@c4-judge @c4-pre-sort @c4-submissions