Benchmark? Comparison? Also the assumption of the structure size which equals to []byte is unacceptable.

@xiaost #370 it just reduce the MOVQ instruction times. the assumption is sliceHeader and stringHeader should not change in the future.

@joway it can be different size for string and stringheader.
reflect.StringHeader will not be changed, but it doesn't mean string can not add more fields to the end of reflect.StringHeader.

func UnsafeStringToSlice(s string) (b []byte) {
	*(*string)(unsafe.Pointer(&b)) = s
	(*reflect.SliceHeader)(unsafe.Pointer(&b)).Cap = len(s)
	return
}

try this code snippet which has better readability if we'd like to sacrifice forward compatibility for the minor optimisation.

I won't do that.

@xiaost
In go1.20, that reflect.StringHeader and reflect.SliceHeader are [officially deprecated]

func UnsafeStringToSlice(s string) []byte {
	return unsafe.Slice(unsafe.StringData(s), len(s))
}

@dxasu I know what you said, but I don't know what is your point.