Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect use of --save flag in installation instructions for React Native SDK #33

Open
mensonones opened this issue Oct 2, 2024 · 7 comments

Comments

@mensonones
Copy link

I encountered an issue while following the installation instructions for the cloudinary-react-native SDK. The documentation suggests using the following command to install the SDK:

yarn add cloudinary-react-native --save

However, when running this command, I receive the following error:

image

In Yarn, the --save flag is not needed as it automatically saves dependencies to package.json. The correct command should be:

yarn add cloudinary-react-native

Please update the documentation to reflect this, as it can cause confusion for users following the installation steps.

Thank you!

yarn --version
3.6.4

@skalahasti-cloudinary
Copy link

Hi @mensonones

Thanks for raising the issue.

However, I am unable to reproduce the issue.

Can you please let us know which version of yarn are you using?

Thanks,
Sree

@mensonones
Copy link
Author

Hi @mensonones

Thanks for raising the issue.

However, I am unable to reproduce the issue.

Can you please let us know which version of yarn are you using?

Thanks, Sree

yarn --version
3.6.4

@skalahasti-cloudinary
Copy link

Thanks @mensonones

I have raised this to our internal team to check if they can reproduce.

Will keep you posted.

Thanks,
Sree

Taussy10 added a commit to Taussy10/cloudinary-react-native that referenced this issue Oct 6, 2024
@Taussy10
Copy link

Taussy10 commented Oct 6, 2024

Hi @mensonones,
I've fixed the issue.

@mensonones
Copy link
Author

Hi @mensonones, I've fixed the issue.

Thanks! I opened a PR with the fix ;)

@Taussy10
Copy link

Taussy10 commented Oct 7, 2024

Hi @mensonones, I've fixed the issue.

Thanks! I opened a PR with the fix ;)

Actually I raised the PR. Could you please review and merge it when you get a chance ?

@michal-sordyl-cloudinary

@mensonones thank you for the contribution, we will review your PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants