You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When SAML authentication fails because of "invalid destination", because the destination does not match the location (see patch below), the resulting error message does not include the location.
The patch below updates the error message to include the value of location which is being compared against destination.
diff --git a/server/src/main/java/org/cloudfoundry/identity/uaa/provider/saml/OpenSaml4AuthenticationProvider.java b/server/src/main/java/org/cloudfoundry/identity/uaa/provider/saml/OpenSaml4AuthenticationProvider.java
index e484a0f13..b5398e269 100644
--- a/server/src/main/java/org/cloudfoundry/identity/uaa/provider/saml/OpenSaml4AuthenticationProvider.java+++ b/server/src/main/java/org/cloudfoundry/identity/uaa/provider/saml/OpenSaml4AuthenticationProvider.java@@ -224,8 +224,8 @@ public final class OpenSaml4AuthenticationProvider implements AuthenticationProv
String destination = response.getDestination();
String location = token.getRelyingPartyRegistration().getAssertionConsumerServiceLocation();
if (StringUtils.hasText(destination) && !destination.equals(location)) {
- String message = "Invalid destination [" + destination + "] for SAML response [" + response.getID()- + "]";+ String message = "Invalid destination [%s], location [%s] combo for samle response [%s]"+ .formatted(destination, location, response.getID());
result = result.concat(new Saml2Error(Saml2ErrorCodes.INVALID_DESTINATION, message));
}
String assertingPartyEntityId = token.getRelyingPartyRegistration()
The text was updated successfully, but these errors were encountered:
When SAML authentication fails because of "invalid destination", because the
destination
does not match thelocation
(see patch below), the resulting error message does not include thelocation
.The patch below updates the error message to include the value of
location
which is being compared againstdestination
.The text was updated successfully, but these errors were encountered: