Add initial module passing all tests #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Melody Sofia Eroshevich <[email protected]>
Signed-off-by: Melody Sofia Eroshevich <[email protected]>
Signed-off-by: Melody Sofia Eroshevich <[email protected]>
Signed-off-by: Melody Sofia Eroshevich <[email protected]>
Signed-off-by: Melody Sofia Eroshevich <[email protected]>
…ration Signed-off-by: Melody Sofia Eroshevich <[email protected]>
Signed-off-by: Melody Sofia Eroshevich <[email protected]>
Signed-off-by: Roman Schwarz <[email protected]>
Signed-off-by: Melody Sofia Eroshevich <[email protected]>
Signed-off-by: Melody Sofia Eroshevich <[email protected]>
…m-mssql-vm Signed-off-by: Roman Schwarz <[email protected]>
Signed-off-by: Roman Schwarz <[email protected]>
Signed-off-by: Roman Schwarz <[email protected]>
Signed-off-by: Roman Schwarz <[email protected]>
Signed-off-by: Roman Schwarz <[email protected]>
Signed-off-by: Roman Schwarz <[email protected]>
Signed-off-by: Roman Schwarz <[email protected]>
Otherwise trusted launch is not possible Signed-off-by: Roman Schwarz <[email protected]>
Signed-off-by: Roman Schwarz <[email protected]>
Signed-off-by: Roman Schwarz <[email protected]>
Signed-off-by: Roman Schwarz <[email protected]>
rswrz
requested review from
lixhunter,
Phil-Thoennissen and
neonwhiskers
as code owners
Signed-off-by: Roman Schwarz <[email protected]>
Signed-off-by: Roman Schwarz <[email protected]>
Signed-off-by: Roman Schwarz <[email protected]>
Signed-off-by: Roman Schwarz <[email protected]>
Signed-off-by: Roman Schwarz <[email protected]>
rswrz
force-pushed
the
2-add-initial-module-terraform-azurerm-mssql-vm
branch
from
3b13b8d to
559ef5d
Compare
Signed-off-by: Roman Schwarz <[email protected]>
rswrz
force-pushed
the
2-add-initial-module-terraform-azurerm-mssql-vm
branch
from
559ef5d to
cde6cfb
Compare
lixhunter
requested changes
Jan 14, 2025
Comment on lines
+175
to
+202
| run "should_fail_on_wrong_file_path" { | ||
| command = plan | ||
|
|
||
| variables { | ||
| storage_configuration = { | ||
| disk_type = "NEW" | ||
| storage_workload_type = "OLTP" | ||
| system_db_on_data_disk_enabled = false | ||
|
|
||
| data_settings = { | ||
| luns = [0] | ||
| disk_size_gb = 64 | ||
| default_file_path = "D:\\data" | ||
| } | ||
| log_settings = { | ||
| luns = [] | ||
| disk_size_gb = 64 | ||
| default_file_path = "G:\\log" | ||
| } | ||
| temp_db_settings = { | ||
| luns = [] | ||
| default_file_path = "H:\\tempDb" | ||
| } | ||
| } | ||
| } | ||
|
|
||
| expect_failures = [var.storage_configuration] | ||
| } |
There was a problem hiding this comment.
I do not understand the testcase. The Paths seems to be valid from test parameter point of view. If the Test ist valid, please add a description to the method or the parameter what should lead to the failure.
Comment on lines
+145
to
+172
| run "should_fail_" { | ||
| command = plan | ||
|
|
||
| variables { | ||
| storage_configuration = { | ||
| disk_type = "NEW" | ||
| storage_workload_type = "OLTP" | ||
| system_db_on_data_disk_enabled = false | ||
|
|
||
| data_settings = { | ||
| luns = [] | ||
| disk_size_gb = 64 | ||
| default_file_path = "D:\\data" | ||
| } | ||
| log_settings = { | ||
| luns = [1] | ||
| disk_size_gb = 64 | ||
| default_file_path = "G:\\log" | ||
| } | ||
| temp_db_settings = { | ||
| luns = [] | ||
| default_file_path = "H:\\tempDb" | ||
| } | ||
| } | ||
| } | ||
|
|
||
| expect_failures = [var.storage_configuration] | ||
| } |
There was a problem hiding this comment.
"should_fail_" may be a oversight. Please choose a name to describe what is tested here.
Comment on lines
+107
to
+110
| # validation { | ||
| # condition = (var.enable_backup_protected_vm && var.backup_policy_id != null) || !var.enable_backup_protected_vm | ||
| # error_message = "A backup policy ID is required when backup_protected_vm.enabled is true." | ||
| # } |
There was a problem hiding this comment.
Comments in examples are OK, when referenced in the Readme. Otherwise remove commented code.
Comment on lines
+137
to
+140
| # validation { | ||
| # condition = var.computer_name == null ? length(var.name) <= 15 : true | ||
| # error_message = "Windows computer name can be at most 15 characters. Variable \"computer_name\" is not set, falling back to \"name\" which is ${length(var.name)} chatacters long. Set \"computer_name\" explicitly." | ||
| # } |
There was a problem hiding this comment.
Comments in examples are OK, when referenced in the Readme. Otherwise remove commented code.
Comment on lines
+290
to
+297
| # validation { | ||
| # condition = var.key_vault_id == null ? ( | ||
| # (var.authentication_type == "Password" && var.admin_password != null) || (var.authentication_type == "SSH" && var.admin_ssh_public_key != null) | ||
| # ) : ( | ||
| # (var.authentication_type == "Password" && var.admin_password == null) || (var.authentication_type == "SSH" && var.admin_ssh_public_key == null) | ||
| # ) | ||
| # error_message = "Invalid combination of key_vault_id, admin_password, and admin_ssh_public_key. If key_vault_id is null, admin_password or admin_ssh_public_key must be non-null. If key_vault_id is not null, admin_password and admin_ssh_public_key must be null." | ||
| # } |
There was a problem hiding this comment.
Comments in examples are OK, when referenced in the Readme. Otherwise remove commented code.
Comment on lines
+152
to
+160
| # dynamic "key_vault_credential" { | ||
| # for_each = var.enable_key_vault_credential ? [true] : [] | ||
| # content { | ||
| # key_vault_url = var.key_vault_credential_key_vault_url | ||
| # name = var.key_vault_credential_name | ||
| # service_principal_name = var.key_vault_credential_service_principal_name | ||
| # service_principal_secret = var.key_vault_credential_service_principal_secret | ||
| # } | ||
| # } |
There was a problem hiding this comment.
Comments in examples are OK, when referenced in the Readme. Otherwise remove commented code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a basic first module for Azure MSSQL on Virtual Machine. The aim is not to have a production-ready module, but a first v0 release.