[WIP] fall back to -no-client behavior if client CLI fails to launch #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is simpler and more comprehensive than checking for the existence of each of the values we pass through, and should catch all of the same errors (though not with the same granularity).
|
hmm. my question is that fallback desired behavior? (the answer could be yes, i'm just asking) typically when you provide arguments, you want it to do that. so by it going back to --no-client, it might be weird UX. code-wise: it LGTM though. |
|
I don't have a major opinion on this, but @jcscottiii 's point rings true for me. The fact that there's now a separate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19.
This is simpler and more comprehensive than checking for the existence of each of the values we pass through, and should catch all of the same errors (though not with the same granularity).
Trying to figure out how best to test this. @jmcarp @jcscottiii Thoughts?