Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create university-of-bucharest-faculty-of-law.csl #6791

Merged
merged 5 commits into from
Sep 11, 2024

Conversation

AlexandruPanait1
Copy link
Contributor

This is the requested style of citation and bibliography to be followed by students of University of Bucharest Faculty of Law in creating their Dissertation Work for all Masters programs (style used since 2018). I would like to contribute to the enlargement of Zotero Style Repository with this html code. Please note that I am a student that was asked by a teacher to create this html code for the sole reason that I remember some html coding from highschool. I created this code unofficially, because our University does not care about the digitalization process and the creation of tools in order to help students. They will not direct resources in creating another code and probably will tolerate the situation. I will speak with the Vice Dean about the existence of this code that will be added to Zotero Style Repository.

This is the requested style of citation and bibliography to be followed by students of University of Bucharest Faculty of Law in creating their Dissertation Work for all Masters programs (style used since 2018).
I would like to contribute to the enlargement of Zotero Style Repository with this html code.
Please note that I am a student that was asked by a teacher to create this html code for the sole reason that I remember some html coding from highschool.
I created this code unofficially, because our University does not care about the digitalization process and the creation of tools in order to help students. They will not direct resources in creating another code and probably will tolerate the situation. I will speak with the Vice Dean about the existence of this code that will be added to Zotero Style Repository.
Copy link

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, click on the ellipsis button in the top-right corner of your style, and then select "Edit file" to start editing:

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

Copy link

😟 There are some issues with your submission.

5 tests failed

dependent/university-of-bucharest-faculty-of-law: must be a dependent style (independent styles must be placed in the root directory)

expected `#<CSL::Style xmlns="http://purl.org/net/xbiblio/csl" version="1.0" class="note" default-locale="ro-RO" page-range-format="expanded" children=[5]>.dependent?` to be truthy, got nil

dependent/university-of-bucharest-faculty-of-law: "independent-parent" link must point to an existing independent style

expected nil to match /^http:\/\/www.zotero.org\/styles\//

dependent/university-of-bucharest-faculty-of-law: may not have <macro/>, <citation/>, or <bibliography/> elements

expected `#<CSL::Style xmlns="http://purl.org/net/xbiblio/csl" version="1.0" class="note" default-locale="ro-RO" page-range-format="expanded" children=[5]>.has_macro?` to be falsey, got true

dependent/university-of-bucharest-faculty-of-law: must have the same citation-format as its independent-parent

undefined method `[]' for nil:NilClass

dependent/university-of-bucharest-faculty-of-law: "self" link must match the style ID

expected: "chrome-extension://efaidnbmnnnibpcajpcglclefindmkaj/https://drept.unibuc.ro/documente/dyn_doc/despre-noi/Metodologie%20elaborare%20lucrare%20disertatie.pdf"
     got: "http://www.zotero.org/styles/university-of-bucharest-faculty-of-law"

(compared using ==)

Please check the test report for details.

@AlexandruPanait1
Copy link
Contributor Author

I see that there are some failures. When I used CSL Validator 1.0.2 strict (for CSL repository) everything was good. My html understanding is low, what should I change to the code? Can you explain to me like you talk to a child? Or if the problem is not so big, can you change it?

Copy link

😟 There are some issues with your submission.

1 test failed

university-of-bucharest-faculty-of-law: "self" link must match the style ID

expected: "https://drept.unibuc.ro/documente/dyn_doc/despre-noi/Metodologie%20elaborare%20lucrare%20disertatie.pdf"
     got: "http://www.zotero.org/styles/university-of-bucharest-faculty-of-law"

(compared using ==)

Please check the test report for details.

Copy link

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

university-of-bucharest-faculty-of-law.csl (new)
A se vedea CSL search by example, Citation Style Editor, 2012; B. Hancké, M. Rhodes, M. Thatcher (dir.), ; Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy, Ed. Oxford University Press, Oxford and New York, 2007.
A se vedea M. Fenner, M. Crosas, J.S. Grethe, D. Kennedy, H. Hermjakob, P. Rocca-Serra, G. Durand, R. Berjon, S. Karcher, M. Martone, T. Clark, ; A data citation roadmap for scholarly data repositories, în Scientific Data, vol. 6, nr. 1 , p. 28; I. Mares, ; Firms and the welfare state: When, why, and how does social policy matter to employers?, în I. Mares, Varieties of capitalism. The institutional foundations of comparative advantage, Oxford University Press, New York, 2001, p. 184–213.

CSL search by example, în Citation Style Editor, 2012.
M. Fenner, M. Crosas, J.S. Grethe, D. Kennedy, H. Hermjakob, P. Rocca-Serra, G. Durand, R. Berjon, S. Karcher, M. Martone, T. Clark, A data citation roadmap for scholarly data repositories, în Scientific Data, vol. 6, nr. 1, 2019, p. 28.
B. Hancké, M. Rhodes, M. Thatcher (dir.), Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy, Ed. Oxford University Press, Oxford and New York, 2007.
I. Mares, Firms and the welfare state: When, why, and how does social policy matter to employers?, in Peter A. Hall și David Soskice (dir.) , Varieties of capitalism. The institutional foundations of comparative advantage, New York, Oxford University Press, 2001, p. 184–213.

@AlexandruPanait1
Copy link
Contributor Author

Thank you for help! I saw that you removed the contributor among many others. I will remove it form summary too.

Copy link

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

university-of-bucharest-faculty-of-law.csl (new)
A se vedea CSL search by example, Citation Style Editor, 2012; B. Hancké, M. Rhodes, M. Thatcher (dir.), ; Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy, Ed. Oxford University Press, Oxford and New York, 2007.
A se vedea M. Fenner, M. Crosas, J.S. Grethe, D. Kennedy, H. Hermjakob, P. Rocca-Serra, G. Durand, R. Berjon, S. Karcher, M. Martone, T. Clark, ; A data citation roadmap for scholarly data repositories, în Scientific Data, vol. 6, nr. 1 , p. 28; I. Mares, ; Firms and the welfare state: When, why, and how does social policy matter to employers?, în I. Mares, Varieties of capitalism. The institutional foundations of comparative advantage, Oxford University Press, New York, 2001, p. 184–213.

CSL search by example, în Citation Style Editor, 2012.
M. Fenner, M. Crosas, J.S. Grethe, D. Kennedy, H. Hermjakob, P. Rocca-Serra, G. Durand, R. Berjon, S. Karcher, M. Martone, T. Clark, A data citation roadmap for scholarly data repositories, în Scientific Data, vol. 6, nr. 1, 2019, p. 28.
B. Hancké, M. Rhodes, M. Thatcher (dir.), Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy, Ed. Oxford University Press, Oxford and New York, 2007.
I. Mares, Firms and the welfare state: When, why, and how does social policy matter to employers?, in Peter A. Hall și David Soskice (dir.) , Varieties of capitalism. The institutional foundations of comparative advantage, New York, Oxford University Press, 2001, p. 184–213.

@AlexandruPanait1
Copy link
Contributor Author

Good afternoon, is there anything else that I have to do in order to post this style in Zotero Style Repository?

Copy link

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

university-of-bucharest-faculty-of-law.csl (new)
A se vedea CSL search by example, ; Citation Style Editor, 2012; B. Hancké, M. Rhodes, M. Thatcher (dir.), ; Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy, Ed. Oxford University Press, Oxford and New York, 2007.
A se vedea M. Fenner, M. Crosas, J.S. Grethe, D. Kennedy, H. Hermjakob, P. Rocca-Serra, G. Durand, R. Berjon, S. Karcher, M. Martone, T. Clark, ; A data citation roadmap for scholarly data repositories, în Scientific Data, vol. 6, nr. 1 , ; p. 28; I. Mares, ; Firms and the welfare state: When, why, and how does social policy matter to employers?, ; în ; I. Mares, Varieties of capitalism. The institutional foundations of comparative advantage, Oxford University Press, New York, 2001, p. 184–213.

CSL search by example, în Citation Style Editor, 2012.
M. Fenner, M. Crosas, J.S. Grethe, D. Kennedy, H. Hermjakob, P. Rocca-Serra, G. Durand, R. Berjon, S. Karcher, M. Martone, T. Clark, A data citation roadmap for scholarly data repositories, în Scientific Data, vol. 6, nr. 1, 2019, p. 28.
B. Hancké, M. Rhodes, M. Thatcher (dir.), Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy, Ed. Oxford University Press, Oxford and New York, 2007.
I. Mares, Firms and the welfare state: When, why, and how does social policy matter to employers?, in Peter A. Hall și David Soskice (dir.) , Varieties of capitalism. The institutional foundations of comparative advantage, New York, Oxford University Press, 2001, p. 184–213.

@bwiernik
Copy link
Member

Thanks for your patience!

@bwiernik bwiernik merged commit 3c102e1 into citation-style-language:master Sep 11, 2024
1 check passed
@github-actions github-actions bot added the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Sep 11, 2024
@AlexandruPanait1
Copy link
Contributor Author

Thanks for your patience!

Not a problem! I am glad to contribute!

@github-actions github-actions bot removed the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants