-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create leidraad-voor-juridische-auteurs-2022.csl #6784
base: master
Are you sure you want to change the base?
Create leidraad-voor-juridische-auteurs-2022.csl #6784
Conversation
Support for the Dutch guidelines for judicial authors 2022 style
Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes. If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements. To update this pull request, visit the "Files changed" tab above, click on the ellipsis button in the top-right corner of your style, and then select "Edit file" to start editing: If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable. |
😟 There are some issues with your submission. 1 test failedleidraad-voor-juridische-auteurs-2022.csl Please check the test report for details. |
Added "Nederlands" to the title |
😃 Your submission passed all our automated tests. Below are some sample citations generated based on your proposed changes: leidraad-voor-juridische-auteurs-2022.csl (new)‘CSL search by example’, http://editor.citationstyles.org/searchByExample/, 2012; Hancké, Rhodes & Thatcher 2007. |
Thanks -- are both the 2019 and the 2022 version in use or should we just replace the 2019 version with this one? |
Good question, as far as I know (I'm just a student) everyone using the 2019 version is recommended to switch over to 2022 . Although I expect that very few people (will) use either of these anyways, I'd keep both just for archival reasons. |
I was wondering if this PR could be merged, or that some extra work is possibly needed? @CaspervanWetten @adam3smith |
As far as I'm concerned this PR can be merged at any moments. I've been using it personally in the meantime and haven't encountered any issues. |
The style looks fine, but we'd want to properly handle the naming (if you want to do this, we'll want this version to replace the existing leidraad style and keep the existing one with a different id/filename/title that clearly labels it -- we typically use edition number, but if edition name is all we have that's what we'll go by. |
This has been quiet for a while. To clarify: the updated Leidraad (most recent, 2022) is the only one that is currently being used, and the only one acceptable for academic purposes. As a result, the 2019 edition should be removed, as it has been updated and replaced by the 2022 version. The changes are relatively small. The code proposed here in #6784 was very clearly based on the work done previously for the 2019 edition, as almost all of the original code remains intact. I would suggest the original authors remain credited with their work, which was most recently updated in #5242. The proposed commit sees the names of those original authors removed. Unfortunately, I don't think I am - at this time - competent enough to verify all the changes made to the "Leidraad" in 2022 are included in the code in this commit, as the full "Leidraad" is a 157 page document on the one hand, and I am unfamiliar with the code (and the language as a whole) on the other. I.e., the most significant change in the Leidraad 2022 is the change to, for the shortened references in footnotes, no longer include the full reference to the academic journal but to instead follow the short-reference rules for books. Example for shortened references, 2019:
Example updated shortened references, 2022:
As a result, I would expect to see a change in the macro reference-book-etc-short, and while a change is made, the proposed commit includes the number-journal-short, which seems not to be accurate with the Leidraad 2022. Furthermore, the term "page" is adjusted from p. to r.o.; in Dutch legalese, r.o. is used as a subsection (generally numbered per paragraph) of a legal decision only, but this is not applicable to (recurring) journals, books, etc. I cannot determine if the code on line 35 of this commit actually changes the output in a relevant way, as some outputs do put "p." for page number Would be happy to help someone with more coding experience to double-check and ensure this is a complete adaptation of the 2022 Leidraad. |
Support for the Dutch guidelines for judicial authors 2022 style