-
-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
verb-short terms #38
Comments
(If this is set up this way by intention, of course, there is no problem.) |
The furthest I could trace this back is http://xbiblio.svn.sourceforge.net/viewvc/xbiblio/csl/locales/locales-en-US.xml?revision=382&view=markup&pathrev=382 , which is before my time. Couldn't find a thread about it on the xbiblio mailing list, either. (I wondered about this myself as well) |
As a further note on this, the following macro in chicago-author-date.csl is likely the original source of many instances of verb-short across the archive.
It should pretty clearly be changed to "short" in this context. |
I think it makes sense to change the translations in the "en-US" and "en-GB" locale files, but existing styles would all need to be checked and either a) be switched from "verb-short" to "short" or b) have the term redefined in the style cs:locale section. |
Checking a style a day, it would take about 3 months. Too bad the work isn't glamorous enough for Summer of Code ... |
I'll look into it. I love menial work. |
completely agree this should be changed. It sounds like it should be I don't have any recollection of any discussions on this either. On Thu, Sep 13, 2012 at 7:57 AM, Rintze M. Zelle
Sebastian Karcher |
I changed a bunch of styles: citation-style-language/styles@4bf538a (I excluded styles that have a default-locale set to a non-English language, and some more complicated cases) I now realize, though, that the short plural="never" replacement might not be enough, because the singular "short" form of "translator" is "tran", while the "verb-short" form is "trans". There is a second difference, for "illustrator", which is "ill." and "illus." in the locale files, respectively. |
the second difference doesn't matter, though, since that's just a couple of On Thu, Sep 13, 2012 at 8:55 PM, Rintze M. Zelle
Sebastian Karcher |
Unless anybody objects, I'm starting to think that it might be easier to just define the "verb-short" term forms in the styles. |
No objection here. |
I wrote a script ( https://github.com/citation-style-language/utilities/blob/master/csl-reindenting-and-verb-short-fix.py ) that defines the affected verb-short terms to the relevant styles. The logic:
a) If there is no cs:locale element, I create one without the The results of the script are here: citation-style-language/styles@88c78ae Could @adam3smith and/or @fbennett take a quick peek to check whether this looks okay? If there are no complaints, I'll update the locale files by adding the "by" preposition. |
Changes to locale files: 92270bb |
The en-US locale contains the following verb-short term nodes:
The preposition "by" is missing from director, editor, editorial-director, illustrator, and translator, although it is present on container-author and editor-translator. I don't know whether this is set up this way by intention, but it is inconsistent, and seems inconsistent with the meaning of the attribute.
Unfortunately, verb-short is used in 81 styles in the repository, and we can assume that it is meant to return the term without the preposition. I don't know how many styles would return container-author or editortranslator (and so expect the preposition to be present on at least some cite forms).
I haven't checked whether other locales reflect the English or follow the semantics of the attribute, but that would be a concern as well. It seems to me that the terms in the verb-short group should be consistent, but I don't have any ideas about how to get there without putting in a lot of work or risking a lot of complaints. Without style-level tests it's hard to judge how much of an outcry there would be if the prepositions were just added where they are missing.
(I recently started shipping a static locale set with citeproc-js for use in testing, and noticed the problem when a flurry of tests failed after I idly "fixed" the terms in the static bundle. I'll adjust the tests to reflect the "fixed" values, but the issue remains in the official locales.)
The text was updated successfully, but these errors were encountered: