-
-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make composer package - Feature request #169
Comments
We're not opposed to accepting this, but we first need to figure out how to add a "composer.json" file to the "styles-distribution" repo. There is discussion for that at citation-style-language/styles#2706 and an incomplete pull request at citation-style-language/distribution-updater#3. If you could help us fix up that PR, we'd consider also adding a "composer.json" file to the "locales" repo. |
As background, https://github.com/citation-style-language/styles-distribution hosts a cleaned-up copy of https://github.com/citation-style-language/styles, and is only updated by https://github.com/citation-style-language/distribution-updater if the Travis CI tests on the "styles" repo complete without errors. I therefore think it makes most sense to add a "composer.json" file to the "styles-distribution" repo (since downstream users should usually pull their styles from there), but this would require some changes to "distribution-updater". The updater isn't my code, and I'm not the best coder, so any help with preparing a good PR would be much appreciated. Once we have that situation figured out adding a composer.json to the "locales" repo would be easy. |
This would be helpful for us. Looks like https://github.com/citation-style-language/styles is already set up this way, and a git tag is created for each commit which is helpful to, so it allows people to "lock" to a specific version of the repo. |
We can add the same composer.json workflow to locales, yes. |
I don't know anything about composer, though, so PRs would be very welcome -- for some reason the maintainer of the packagist package (who also maintains the one for citeproc-php) hasn't been responding to my mentions of him here recently, so might be worth trying to get in touch with him otherwise. |
Hi @adam3smith. |
It's good enough for this purpose |
@adam3smith |
I'd much rather someone with even a basic understanding of the PhP ecosystem would do that. Any way that @seboettg (who maintains the styles one) would be willing to? |
https://github.com/seboettg/locales/blob/master/composer.json looks fine by me, but not by packagist.
I don't know whether it's really necessary to have the |
I think |
Thanks @seboettg -- this is now on packagist as well https://packagist.org/packages/citation-style-language/locales |
Motivation
We using your project in our PHP project.
The best way to manage PHP(and any other) project requirements is package checking/updating.
The most popular package manager is Composer.
Potential solving
Can you make composer package from your project?
Example of composer.json file which must be in the root folder of project attached(archived for attaching).
composer.json.zip
The text was updated successfully, but these errors were encountered: