Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn reports into a proper Python package #50

Open
jsf9k opened this issue Feb 25, 2022 · 2 comments
Open

Turn reports into a proper Python package #50

jsf9k opened this issue Feb 25, 2022 · 2 comments
Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use

Comments

@jsf9k
Copy link
Member

jsf9k commented Feb 25, 2022

I prefer absolute imports for things like this.

from . import graphs

Originally posted by @mcdonnnj in #46 (comment)
@jsf9k jsf9k added the improvement This issue or pull request will add or improve functionality, maintainability, or ease of use label Feb 25, 2022
@jsf9k
Copy link
Member Author

jsf9k commented Feb 25, 2022

Unfortunately @mcdonnnj's excellent suggestion was refused at runtime because the code in src/report is not a Python package. This should be remedied, so that @mcdonnnj's suggested change can be applied.

jsf9k added a commit that referenced this issue Feb 25, 2022
@jsf9k
Revert "Use an absolute import"
fa8f6e3 
This reverts commit 61cf660.

This change was rejected at runtime since the code in src/report does
not constitute a Python package.  See also issue #50.
@jsf9k jsf9k mentioned this issue Feb 25, 2022
Merged
10 tasks
@mcdonnnj
Copy link
Member

mcdonnnj commented Mar 1, 2022

Building on this I would like to see this repository lose all of its Docker elements and become just the Python package. Then a cisagov/pshtt_reporter-docker or equivalent repository would Docker-ize the Python package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jsf9k @mcdonnnj