aws_security_group idempotency workaround

[gmiranda23]

Running the default (create entire lab) recipe bombs out because the aws_security_group resource runs into this bug. The bug has a known work around. Implement the workaround until such time as the (currently triaged) bug is addressed in a future release of chef-provisioning-aws.

[gmiranda23]

Addressed by #44. Leaving this issue open as a reminder to circle back once the initial chef-provisioning-aws issue is fixed.

[burtlo]

After destroying portal chef-client -z -r 'recipe[chef_classroom::destroy_portal]' and attempting to re-deply portal chef-client -z -r 'recipe[chef_classroom::deploy_portal]'. I receive the following error:

    Error executing action `converge` on resource 'machine[frank-training-portal]'
    ================================================================================

    RuntimeError
    ------------
    Chef::Resource::AwsSecurityGroup[training-frank-training-portal] does not exist!

    Resource Declaration:
    ---------------------
    # In /Users/franklinwebber/training/provisioners/chef_classroom/local-mode-cache/cache/cookbooks/chef_classroom/recipes/deploy_portal.rb

     44: machine "#{name}-portal" do
     45:   machine_options create_machine_options(region, 'centos', portal_size, workstation_key, 'portal')
     46:   recipe 'chef_portal::fundamentals_3x'
     47:   converge true
     48: end

    Compiled Resource:
    ------------------
    # Declared in /Users/franklinwebber/training/provisioners/chef_classroom/local-mode-cache/cache/cookbooks/chef_classroom/recipes/deploy_portal.rb:44:in `from_file'

    machine("frank-training-portal") do
      action :converge
      retries 0
      retry_delay 2
      default_guard_interpreter :default
      chef_server {:chef_server_url=>"chefzero://localhost:8889", :options=>{:client_name=>"local_workstation", :signing_key_filename=>nil}}
      driver "aws::us-east-1"
      machine_options {:region=>"us-east-1", :ssh_username=>"root", :convergence_options=>{:ssl_verify_mode=>:verify_none, :chef_version=>"12.2.1"}, :bootstrap_options=>{:instance_type=>"m3.medium", :image_id=>"ami-c2a818aa", :key_name=>"frank-training-workstation_key", :security_group_ids=>"training-frank-training-portal", :iam_instance_profile=>"arn:aws:iam::404885260443:instance-profile/classroom"}}
      declared_type :machine
      cookbook_name "chef_classroom"
      recipe_name "deploy_portal"
      run_list_modifiers [#<Chef::RunList::RunListItem:0x007fda37f769f8 @version=nil, @type=:recipe, @name="chef_portal::fundamentals_3x">]
      converge true
    end

[2015-10-12T13:04:33-07:00] INFO: Running queued delayed notifications before re-raising exception