Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run server side hooks in own namespace #625

Open
NHAS opened this issue Dec 24, 2024 · 0 comments
Open

Run server side hooks in own namespace #625

NHAS opened this issue Dec 24, 2024 · 0 comments

Comments

@NHAS
Copy link

NHAS commented Dec 24, 2024

Describe the solution you'd like
Currently, server side hooks, both globally and individually for repos run the shell scripts or executables with the same permissions as soft-server itself.
This means that if a malicious user was able to write a file onto the disk, or if a hook was written improperly the malicious user would be able to take control of the soft-serve instance.

To remedy this it would be better practice to run the hooks in a namespace, similar to how bubblewrap (https://github.com/containers/bubblewrap) works.
Thus you could isolate a git repo and deprivilege the command execution on hook run.

There are numerous options that could then be considered to restricting the namespace privileges, such as disabling networking which would render most remote code execution useless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant