You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, we are using tls.Config.GetCertificate() to retrieve the certificate from the cert property of keypairReloader. Additionally, we're running a goroutine as part of newKeypairReloader that waits 60 seconds before updating the cert property of keypairReloader.
Because GetCertificate is called upon each ClientHello, this extra gorountine and timer represents an unnecessary step in the process and should be removed, with the process of loading the configured TLS keypair into a keypair object moved into maybeReload, which itself should be called in the function returned by GetCertificate.
The text was updated successfully, but these errors were encountered:
Summary
Currently, we are using tls.Config.GetCertificate() to retrieve the certificate from the
cert
property of keypairReloader. Additionally, we're running a goroutine as part of newKeypairReloader that waits 60 seconds before updating thecert
property ofkeypairReloader
.Because
GetCertificate
is called upon each ClientHello, this extra gorountine and timer represents an unnecessary step in the process and should be removed, with the process of loading the configured TLS keypair into a keypair object moved into maybeReload, which itself should be called in the function returned byGetCertificate
.The text was updated successfully, but these errors were encountered: