Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use cobra flags #38

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

use cobra flags #38

wants to merge 4 commits into from

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Jan 21, 2025

Fixes: #10

@cpanato cpanato mentioned this pull request Jan 21, 2025
Open
@cpanato cpanato requested a review from amouat January 21, 2025 13:05
amouat
amouat reviewed Jan 21, 2025
View reviewed changes
Copy link
Collaborator

@amouat amouat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this a lot, but it is a breaking change. Do we need to communicate this?

@cpanato
Copy link
Member Author

cpanato commented Jan 21, 2025

I like this a lot, but it is a breaking change. Do we need to communicate this?

we can make a minor bump and in the release notes we add a note that is not with -- instead - for the flags

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amouat amouat amouat left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add argument parsing library
2 participants
@cpanato @amouat