You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Right now, when running docker inspect on an apko generated image, the Config.Labels. field is set to null.
It would be nice to add support similar to what exists for annotations (config file/ --annotations support), but for labels instead.
Context
On annotations vs labels, here's my understanding (please chime in if I'm missing anything):
OCI Image Configuration file - This is what you see when you e.g. docker inspect and has the Config.Labels field
Notably (1) and (2) support annotations (3) supports labels (again - What you can view with docker inspect).
You can view annotations on (1) and (2) via docker buildx imagetools inspect ..., but annotations != labels. They kind of match in spec (?), but my understanding is the distinction is where they show up.
APKO supports annotations with (1) and (2).
It does not support (3).
Question
I see this PR open here that would merge annotations and labels - Anything provided as an annotations would become a label in the OCI image configuration file (shows up w/ docker inspect).
I wanted to ask so we can contribute either of them / merge the above PR / etc to see labels functionality -
Is the goal to:
A - Just allow users to provide annotations, and put them in all (3) locations?
B - Allow users to provide annotations that go into (1) and (2), but also provide labels that only go to (3)?
C - Something else?
Seeking clarification on how labels vs annotations ought to behave in apko and so it can be contributed.
Thank you!
The text was updated successfully, but these errors were encountered:
@kaniini would you be able to chime in on preferred approach? We're eager to contribute it ASAP whichever direction you prefer. Alternatively, if there's a best person to raise this design question to, would appreciate it!!!
Right now, when running
docker inspect
on anapko
generated image, theConfig.Labels.
field is set to null.It would be nice to add support similar to what exists for annotations (config file/ --annotations support), but for labels instead.
Context
On annotations vs labels, here's my understanding (please chime in if I'm missing anything):
There's (3) major OCI config/manifest files.
Notably (1) and (2) support annotations (3) supports labels (again - What you can view with docker inspect).
You can view annotations on (1) and (2) via
docker buildx imagetools inspect ...
, but annotations != labels. They kind of match in spec (?), but my understanding is the distinction is where they show up.APKO supports annotations with (1) and (2).
It does not support (3).
Question
I see this PR open here that would merge annotations and labels - Anything provided as an annotations would become a label in the OCI image configuration file (shows up w/ docker inspect).
I wanted to ask so we can contribute either of them / merge the above PR / etc to see labels functionality -
Is the goal to:
A - Just allow users to provide annotations, and put them in all (3) locations?
B - Allow users to provide annotations that go into (1) and (2), but also provide labels that only go to (3)?
C - Something else?
Seeking clarification on how labels vs annotations ought to behave in apko and so it can be contributed.
Thank you!
The text was updated successfully, but these errors were encountered: