Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract their names out of the generators #2

Open
mgoeminne opened this issue Nov 23, 2016 · 0 comments
Open

Extract their names out of the generators #2

mgoeminne opened this issue Nov 23, 2016 · 0 comments
Assignees
Milestone

Comments

@mgoeminne
Copy link
Contributor

Currently each generator may have a specific name. This is not very elegant since

  1. Only top-level generator names are useful, but any generator may have a name.
  2. All the generator objects have a Some[String] attribute for storing their name, and they don't really them.
  3. By nature, the notion of "name" is not related to the notion of generator. The names are only used to refer to "external" generators in JSON documents storing such generators.

I propose to remove the "name" attribute from the generator objects, and to consider their name as a meta-information. From the perspective of JSON configuration documents, the "generators" attributes will therefore become:

"generators": {
   "name-here": {…}
}
@mgoeminne mgoeminne added this to the 0.2.0 milestone Nov 23, 2016
@mgoeminne mgoeminne self-assigned this Nov 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant