Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make wf_id optional on normalize_collaborations #654

Open
2 tasks
DonHaul opened this issue Jan 9, 2025 · 1 comment
Open
2 tasks

make wf_id optional on normalize_collaborations #654

DonHaul opened this issue Jan 9, 2025 · 1 comment
Assignees
Labels

Comments

@DonHaul
Copy link
Collaborator

DonHaul commented Jan 9, 2025

While working on normalize_collaborations we've noticed that the the wf_if is being passed through to /curation/literature/collaborations-normalization for the sole purpose of logging.

PS: We could also completely remove it although this might be a bit trickier to do. Discuss First

Actions:

@drjova
Copy link
Contributor

drjova commented Jan 10, 2025

@DonHaul I would suggest, default to be None to avoid hardcoded values and clarity.

@DonHaul DonHaul self-assigned this Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants