Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression in 404 branch - local_aws dependency was re-added #655

Open
guillogo opened this issue Jan 8, 2025 · 1 comment
Open

Regression in 404 branch - local_aws dependency was re-added #655

guillogo opened this issue Jan 8, 2025 · 1 comment

Comments

@guillogo
Copy link
Contributor

guillogo commented Jan 8, 2025

Hi all,

A call to local_aws was re-added in MOODLE_404_STABLE branch in the latest commit: c11315c

moodle-tool_objectfs/classes/local/store/s3/client.php

Line 32 in c11315c

use local_aws\admin_settings_aws_region;

This may have been done by mistake when adding object tagging commit.

Best regards,
Guillermo
niko-hoogeveen added a commit to niko-hoogeveen/moodle-tool_objectfs that referenced this issue Jan 8, 2025
@niko-hoogeveen
Issue catalyst#655: Remove import of local_aws
7eee2d4
@guillogo guillogo changed the title Regresion in 404 branch - local_aws dependency was re-added Regression in 404 branch - local_aws dependency was re-added Jan 8, 2025
@niko-hoogeveen niko-hoogeveen mentioned this issue Jan 8, 2025
Merged
@niko-hoogeveen
Copy link
Contributor

niko-hoogeveen commented Jan 8, 2025 •
edited by guillogo
Loading

Hi all, #656 addresses this issue and will allow objectfs to remain independent of local_aws.

Thank you,
Niko

brendanheywood added a commit that referenced this issue Jan 21, 2025
@brendanheywood
Merge pull request #656 from niko-hoogeveen/MOODLE_404_STABLE_issue655
55f2a4b 
Issue #655: Remove import of local_aws
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@guillogo @niko-hoogeveen