-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial selection of reviewed charms #205
Comments
I looked at the three PRs. Thank you! They look very promising. However, right now they all depend on interfaces that are still under a personal account. Let's discuss that tomorrow. Mostly: I like what I see; my issues are not about functionality nor (at first pass) about the logic, but about what would make these great examples; namely: comments and docstrings explaining what's going on, what the intent is, etc. After that, naming and formatting issues. And, to repeat, because we want these to be our example charms, we need to look recursively into the interface components and bring all of it up to the right level. |
I've renamed the issue so that we track other initial charms up for review here as well. |
is the 'minimal' Ubuntu-lite charm. |
is also a charm to track. |
I might as well add these too: |
I'm closing this issue, as we're tracking these things separately now. Thank you all! |
Opening this issue to track PRs for 3 example charms:
canonical/cockroachdb-operator#1
canonical/haproxy-operator#1
canonical/keepalived-vrrp-operator#1
A bundle example can be found here:
https://github.com/dshcherb/bundle-cockroachdb-ha
The text was updated successfully, but these errors were encountered: