Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial selection of reviewed charms #205

Closed
dshcherb opened this issue Apr 1, 2020 · 6 comments
Closed

Initial selection of reviewed charms #205

dshcherb opened this issue Apr 1, 2020 · 6 comments

Comments

@dshcherb
Copy link
Contributor

dshcherb commented Apr 1, 2020

Opening this issue to track PRs for 3 example charms:

canonical/cockroachdb-operator#1
canonical/haproxy-operator#1
canonical/keepalived-vrrp-operator#1

A bundle example can be found here:
https://github.com/dshcherb/bundle-cockroachdb-ha

@chipaca
Copy link
Contributor

chipaca commented Apr 1, 2020

I looked at the three PRs. Thank you! They look very promising.

However, right now they all depend on interfaces that are still under a personal account.
If these are to be our examples (and I don't see why not), then they should build on things in the framework itself, or at least on components that are of an adequate quality with shared ownership -- which means we need to look at those components and discuss onboarding them one way or the other.

Let's discuss that tomorrow.

Mostly: I like what I see; my issues are not about functionality nor (at first pass) about the logic, but about what would make these great examples; namely: comments and docstrings explaining what's going on, what the intent is, etc. After that, naming and formatting issues. And, to repeat, because we want these to be our example charms, we need to look recursively into the interface components and bring all of it up to the right level.

@niemeyer niemeyer changed the title Charms for Review: {cockroachdb, haproxy, keepalived} Initial selection of reviewed charms Apr 6, 2020
@niemeyer
Copy link
Collaborator

niemeyer commented Apr 6, 2020

I've renamed the issue so that we track other initial charms up for review here as well.

@jameinel
Copy link
Member

jameinel commented Apr 7, 2020

jameinel/ubuntu-lite#2

is the 'minimal' Ubuntu-lite charm.

@jameinel
Copy link
Member

@relaxdiego
Copy link

@chipaca
Copy link
Contributor

chipaca commented May 20, 2020

I'm closing this issue, as we're tracking these things separately now. Thank you all!

@chipaca chipaca closed this as completed May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants