Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release for more platforms #6

Open
3 of 5 tasks
cameron-martin opened this issue Jan 22, 2024 · 7 comments
Open
3 of 5 tasks

Release for more platforms #6

cameron-martin opened this issue Jan 22, 2024 · 7 comments

Comments

@cameron-martin
Copy link
Owner

cameron-martin commented Jan 22, 2024 •
edited
Loading

Currently it only uploads x86 Linux builds. We should do this for more platforms, for example:
cameron-martin added a commit that referenced this issue Feb 1, 2024
@cameron-martin
ci: Build, test and release on more platforms
abe5a97 
This runs the build on multiple platforms, uploads the artifacts for the release process to subsequently download.

This only builds for x86 on windows, osx and linux. For arm64 cross-compiling will need to be set up.

Works towards #6
@cameron-martin cameron-martin mentioned this issue Feb 1, 2024
Merged
@cameron-martin
Copy link
Owner Author

Building for windows requires fixing bazelbuild/rules_rust#2454.

@cameron-martin
Copy link
Owner Author

Cross-compiling (to arm64) requires fixing bazelbuild/rules_rust#2419

@cameron-martin cameron-martin mentioned this issue Feb 19, 2024
Merged
cameron-martin added a commit that referenced this issue Feb 19, 2024
@cameron-martin
ci: Add M1 mac build (#19)
8085bb9 
Works towards #6
@ar3s3ru
Copy link

ar3s3ru commented Mar 7, 2024

Why not supporting linux-aarch64 too?

@cameron-martin
Copy link
Owner Author

I can do, if there's demand for it. Only problem is I can't test on this platform since GitHub actions doesn't have any runners.

Out of interest, what aarch64 system are you using with Linux?

Repository owner deleted a comment from isedwards Apr 27, 2024
@github-staff github-staff deleted a comment from felixovelar Apr 30, 2024
@github-staff github-staff deleted a comment from felixovelar Apr 30, 2024
@bobzoller
Copy link

bobzoller commented Jun 18, 2024 •
edited
Loading

Came here looking for a linux arm64 build, use case is running within a container under Docker Desktop for Mac. (debian bookworm base image)

@cameron-martin
Copy link
Owner Author

Since GitHub actions doesn't support arm64 Linux, I think the options are either:

  • Cross compile but don't test it and just hope it works. Maybe this is okay because there shouldn't be much platform-specific.
  • Build and test it in a docker container on arm64 OSX.

@cameron-martin
Copy link
Owner Author

Regarding arm64 linux runners, they should be available for open source repos very soon: https://github.com/orgs/community/discussions/19197#discussioncomment-10550689

I think waiting until then is the best option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bobzoller @cameron-martin @ar3s3ru