From 3da76940023bb81add3721af28fb7413fa1be924 Mon Sep 17 00:00:00 2001 From: Anik Dhabal Babu <81948346+anikdhabal@users.noreply.github.com> Date: Fri, 10 Jan 2025 17:17:12 +0530 Subject: [PATCH] fix: flaky e2e test in saml.e2e (#18559) * chore: skip failure e2e test * Update .env * Update manage-booking-questions.e2e.ts * Update manage-booking-questions.e2e.ts * Update manage-booking-questions.e2e.ts * Update manage-booking-questions.e2e.ts * Update manage-booking-questions.e2e.ts * Update manage-booking-questions.e2e.ts * Update .env * Update manage-booking-questions.e2e.ts * fix * fix flake * Update saml.e2e.ts --- apps/web/playwright/saml.e2e.ts | 3 +++ 1 file changed, 3 insertions(+) diff --git a/apps/web/playwright/saml.e2e.ts b/apps/web/playwright/saml.e2e.ts index 7c6425e2dc234b..7af9ba9664446a 100644 --- a/apps/web/playwright/saml.e2e.ts +++ b/apps/web/playwright/saml.e2e.ts @@ -16,6 +16,9 @@ test.describe("SAML tests", () => { // TODO: Figure out a way to use the users from fixtures here, right now we cannot set // the SAML_ADMINS env variables dynamically await login({ username: "pro", email: "pro@example.com", password: "pro" }, page); + const shellLocator = page.locator(`[data-testid=dashboard-shell]`); + await page.waitForURL("/event-types"); + await expect(shellLocator).toBeVisible(); // eslint-disable-next-line playwright/no-skipped-test // Try to go Security page await page.goto("/settings/security/sso");