Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixnum deprecation warning on pagination #53

Closed
martijnbleeker opened this issue Jul 3, 2017 · 2 comments
Closed

Fixnum deprecation warning on pagination #53

martijnbleeker opened this issue Jul 3, 2017 · 2 comments

Comments

@martijnbleeker
Copy link
Contributor

The will_paginate-bootstrap gem is no longer maintained and the readme mentions no PRs are accepted anymore. However, it causes a Fixnum deprecation warning when a paginated index page is loaded.

~/.gem/ruby/2.4.1/gems/will_paginate-bootstrap-1.0.1/lib/bootstrap_pagination/bootstrap_renderer.rb:11: warning: constant ::Fixnum is deprecated

This PR solves the issue, but as mentioned before, the maintainer no longer accepts PRs.
@wvengen
Copy link
Collaborator

wvengen commented Jul 3, 2017

Perhaps bootstrap-will_paginate would be an option?

@jvdp jvdp closed this as completed in 5ee51fd Nov 21, 2018
@jvdp
Copy link
Contributor

jvdp commented Nov 21, 2018

Fixed in 2.5.0!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jvdp @martijnbleeker @wvengen