Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate Squid Router to Swap and Bridge #41049

Closed
6 tasks
onyb opened this issue Sep 13, 2024 · 1 comment · Fixed by brave/brave-core#25676
Closed
6 tasks

Integrate Squid Router to Swap and Bridge #41049

onyb opened this issue Sep 13, 2024 · 1 comment · Fixed by brave/brave-core#25676
Assignees
@onyb
Labels
feature/web3/wallet/core feature/web3/wallet/swap feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.74.x - Release

Comments

@onyb
Copy link
Member

onyb commented Sep 13, 2024

Description

We would like to have Squid Router as an additional provider for fetching swap and bridge quotes

Steps to reproduce

  1. Open Swap / Bridge
  2. Select Squid as the provider preference
  3. Set the tokens and enter the amount to fetch a quote

Actual result

N/A

Expected result

Swap / bridge quote should be fetched via Squid Router API. Boost mode should be supported.

Reproduces how often

Easily reproduced

Brave version (brave://version info)

N/A

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

No response
@onyb onyb self-assigned this Sep 13, 2024
@onyb onyb added feature/web3/wallet/swap QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes feature/web3/wallet/core labels Sep 13, 2024
@onyb onyb added this to Web3 Sep 13, 2024
@onyb onyb moved this to In Progress in Web3 Sep 13, 2024
@onyb onyb mentioned this issue Sep 20, 2024
Merged
24 tasks
@github-project-automation github-project-automation bot moved this from In Progress to Done in Web3 Oct 14, 2024
@brave-builds brave-builds added this to the 1.73.x - Nightly milestone Oct 14, 2024
@srirambv
Copy link
Contributor

srirambv commented Nov 20, 2024 •
edited
Loading

Verification passed on

Brave 1.74.9 Chromium: 131.0.6778.85 (Official Build) beta (64-bit)
Revision 30ceb433b8a77b995214506d3d862edb3220614b
OS Windows 11 Version 23H2 (Build 22631.4460)
  • Verified steps from brave/brave-core#25676
  • Verified Squid is available as a Swap/Bridge provider
  • Verified entering amount and Swap/Bridge tokens generates quote
  • Verified quote refresh for every 30sec
  • Encountered #42395
41049.mp4

@LaurenWags LaurenWags mentioned this issue Jan 14, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@onyb onyb

Labels
feature/web3/wallet/core feature/web3/wallet/swap feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.74.x - Release
Development

Successfully merging a pull request may close this issue.

feat(wallet): add squid to cross-chain swap providers brave/brave-core
3 participants
@onyb @srirambv @brave-builds