Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Leo] Support modifying user prompt on iOS #39831

Closed
yrliou opened this issue Jul 17, 2024 · 1 comment · Fixed by brave/brave-core#24830
Closed

[Leo] Support modifying user prompt on iOS #39831

yrliou opened this issue Jul 17, 2024 · 1 comment · Fixed by brave/brave-core#24830

Comments

@yrliou
Copy link
Member

yrliou commented Jul 17, 2024

Platforms

iOS

Description

brave/brave-core#24558 only makes it compile on iOS with new API changes, this issue is for tracking the iOS work to support it.
cc @StephenHeaps

@yrliou yrliou added the OS/iOS Fixes related to iOS browser functionality label Jul 17, 2024
@StephenHeaps StephenHeaps self-assigned this Jul 17, 2024
@StephenHeaps StephenHeaps moved this to In Progress in Browser AI Jul 25, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Browser AI Jul 29, 2024
@brave-builds brave-builds added this to the 1.70.x - Nightly milestone Jul 29, 2024
@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Oct 2, 2024
@hffvld
Copy link
Contributor

hffvld commented Oct 2, 2024

Verified on iPhone 14 and iPad Mini (6th gen) using version(s):

Device/OS: 
- iPhone 14 / iOS 17.7
- iPad Mni (6th gen) / iPadOS 18
Brave build: 1.70 (123)
BraveCore: 1.70.123 (129.0.6668.89)

STEPS:

  1. Launch Brave
  2. Open Leo
  3. Type any query > Send request
  4. Wait for Leo's response
  5. Tap and hold your query > Verify, that Edit Promt exist
  6. Tap Edit Prompt > Edit your query > Tap ✅ > Verify that the Edited button appeared, and the timestamp is updated

ACTUAL RESULTS:

  • Verified that the user can edit a query.
  • Verified that Leo gives a new response to an updated query.
  • Verified that the Edited label appeared on the right side.
  • Verified that the string contains Edited with a new timestamp updated each time after the query was updated.

iPhone 14 / iOS 17.7

1 2 3 4 5
1 2 3 4 5
1 2 3 4 5
2024-10-01_17-42-41.mp4

iPad Mni (6th gen) / iPadOS 18

1 2 3 4 5
1 2 3 4 5
1 2 3 4 5

@hffvld hffvld added QA Pass - iPhone QA Pass - iPad and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants