New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

False posititive in URL comparison #646

Closed

alandefreitas opened this issue Dec 22, 2022 · 0 comments · Fixed by #645

Member

alandefreitas commented Dec 22, 2022 •

edited

Loading

The compare function would compare an absent component and an empty component as the same thing, but that's wrong.

BOOST_TEST_EQ(url("https:"), url("https://"));
BOOST_TEST_EQ(url("https://@www.boost.org"), url("https://www.boost.org"));
BOOST_TEST_EQ(url("https:"), url("https:?"));
BOOST_TEST_EQ(url("https:"), url("https:#"));
// ... etc

should fail.

The text was updated successfully, but these errors were encountered:

alandefreitas linked a pull request

that will close this issue

comparison differentiates absent and empty components #645

Merged

alandefreitas closed this as completed in #645

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment