Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update alpha handling when we're ready to deprecate Kakadu v7 #61

Open
mel-mason opened this issue Mar 21, 2024 · 0 comments
Open

Update alpha handling when we're ready to deprecate Kakadu v7 #61

mel-mason opened this issue Mar 21, 2024 · 0 comments

Comments

@mel-mason
Copy link
Member

From the kakadu change notes:

Changes from KDU-8.0.5 to KDU-8.0.6
...
e) Corrected the accidental assignment of TIFF tag code 1 to the constant
`KDU_TIFF_ExtraSamples_UNASSOCIATED_ALPHA', as opposed to 2, which
resulted in PREMULTIPLIED and UNASSOCIATED alpha channels being
confused when reading/writing TIFF files. After fixing this error
and making some associated changes in "kdu_compress", "kdu_expand" and
"kdu_v_compress", all these demo-apps (and now "kdu_v_expand" also)
correctly read/write TIFF files with both premultiplied and unassociated
alpha channels, without the need for command-line hints like "-jp2_alpha".

This suggests that we can remove the warnings about unassociated alpha channels on the check suitable for jp2 conversion method, and also perhaps remove the jp2_alpha argument added when converting RGBA files. (It may still be necessary for RGBX files).

As is the code works with both v7.10 and the latest v8.4, so I think it's best to leave as is for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant